Conversation
The internal mkosi naming scheme has been changed from YYYYMMDDHHMMSS to YYYYMMDD.V where the V is an internal version number that increments by 1 each time a new image is built. This is in line with how Universal Blue (in particular Aurora) tags their image versions. Additionally, the $IMAGE_VERSION variable is now exported to os-release. Signed-off-by: SmuJB <smujaybdev@protonmail.com>
Signed-off-by: SmuJB <smujaybdev@protonmail.com>
build_push instead of generate_matrix Signed-off-by: SmuJB <smujaybdev@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to an image naming scheme similar to Universal Blue, where images are named
YYYYMMDD.Vinstead of simplyYYYYMMDD. TheVis a version number for disambiguation and it increments by 1 for every build on the same day.mkosi.bumphas been rewritten in Python to first check the existingmkosi.versionand increment it if necessary according to this versioning scheme. Index starts at 0, so the first image built on any given day will beYYYYMMDD.0. This phases out the messy hack that was used before of usingYYYYMMDDHHMMSSas the versionmkosi.bumpwould return and then separately versioning the image itself.Features:
/etc/os-releasenow has the version of the currently booted image underIMAGE_VERSIONbootc statuswill list the version associated with every deploymentNOTE: This is a draft PR. I have tested that it builds and bumps correctly locally, but I have not been able to test the CI or a live system myself. It is worth testing this to make sure the change didn't break anything, however I have made very similar changes to Amethyris and Apollo and did most of my troubleshooting there.