gnrc_priority_pktqueue: simplify API#1
Merged
zhuoshuguo merged 1 commit intoOct 19, 2016
Merged
Conversation
Owner
|
Thanks a lot! Martine @miri64 , so the idea is to allocate the node externally by the API user itself. |
Author
|
Yapp, like in the rest of RIOT ;-) |
zhuoshuguo
pushed a commit
that referenced
this pull request
Jan 22, 2019
* drivers/ccs811: fix types in debug messages * drivers/driver_ccs811_full: fix unused variable build error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a lot simplification possible, if you do not add the pool of nodes to the queue and let the "user" handle it externally. One would now go to allocate a node like this (sometimes a node allocated somewhere in a function allocated might already be enough for an application so a central array would be overkill). Also there are a lot of style issues that I did not fix with this PR that need fixing before we can merge RIOT-OS#5950!
With this change one would now push a packet
pktto the queueqas follows:Style-note: the functions need
gnrc_prefixing of course ;-)