Fix critical sales and log consistency bugs - #86
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
creditcould be submitted even though no settlement/receivables flow exists, creating completed sales with unsupported payment state.content_type_id=0, causing foreign-key failures; delete could remove the file before reporting failure.Root cause
Fix
sale_detailread-only.accounttobalanceand rejected unsupported payment methods in create/complete flows; replaced the exposed credit button with supportedother.content_type_id=None.Validation
python manage.py test inventory.tests.test_sale_status inventory.tests.test_sales_balance_payment inventory.tests.test_views.LogFileViewTest(17 tests OK; expected GET 405 log)python manage.py check(passes with existing staticfiles.W004 warning)