Fix backup restore confirmation flow - #84
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The active backup restore page rendered the shared restore template without the
backupobject it expects, so opening a backup restore page could fail while reversing the form action. If the page did render, the form submittedconfirm_restorebut the view only checkedconfirm, preventing operators from restoring backups through the browser.Root cause
The refactored active backup view passed
backup_name/backup_infowhile the template usesbackup.name, and the POST confirmation field diverged from the template checkbox name.Fix
backupcontext used by the restore template.confirm_restorefield while preserving the legacyconfirmfield.Validation
mkdir -p logs && .venv/bin/python manage.py test inventory.tests.test_views.BackupViewSecurityTestmkdir -p logs && .venv/bin/python manage.py checkBoth passed;
manage.py checkonly reports the existingstaticfiles.W004warning for missing/workspace/static.