Fix critical sales and log audit regressions - #81
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Xianist Lab <zhtyyx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
creditpayment values despite no receivables/settlement handling, allowing completed sales with inventory/member side effects but no valid payment record.content_type_id=0, causing failures; delete could remove a file while reporting failure.Root cause
SaleFormdoes not validatepayment_method, and the view trusted raw POST/UI values.LogEntry.content_typeis nullable, but the code wrote a nonexistent FK id.Fix
account -> balance, rejected unsupported methods and one-step mixed payments, and replaced the exposed credit button withother.content_type=None.Validation
mkdir -p logs && .venv/bin/python manage.py test inventory.tests.test_sale_status inventory.tests.test_sales_balance_payment inventory.tests.test_views.LogFileViewTestmkdir -p logs && .venv/bin/python manage.py checkNote: validation only reports the existing
staticfiles.W004warning for missing/workspace/static; the sale item GET test intentionally logs a 405.