fix: 修复库存操作按钮无响应 - #69
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
Owner
|
@dajiaohuang 方便加个联系方式聊一下吗, zhtyyx@gmail.com |
Owner
|
感谢提交 PR,这里面确实有一些有价值的修复,比如库存入库/出库/调整按钮、商品导入导出、退货、用户扩展信息等方向都能对应现有 issue。 另外其中有几处高风险点还需要进一步处理:
建议把这个 PR 拆成几个更小的 PR:
这样每个 PR 都能独立 review、测试和合并,也更容易保证主分支稳定。 |
Author
|
感谢详细反馈。我已按建议把这个 PR 收敛为只修复“库存入库/出库/调整按钮无响应”,并基于最新 本次提交
验证结果:聚焦的 联系方式可以通过您留下的邮箱;为了方便 review 和后续追踪,本次代码调整与验证结果也完整保留在这里。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
调整说明
根据维护建议,本 PR 已收敛为一个独立改动:仅修复库存列表的入库、出库、调整按钮无响应。原 PR 中的商品导入导出、颜色/尺码管理、退货流程和 UserProfile 改动均已移除,后续如继续处理会分别讨论和提交。
修复内容
href="#"按钮连接到对应库存操作页面,并携带当前商品的product_id。验证
python manage.py test inventory.tests.test_views.InventoryViewTest --verbosity 2:4 项通过。python manage.py check:通过;仅有仓库既有的static/目录缺失警告。python manage.py makemigrations --check --dry-run:无迁移变化。upstream/main上单独复现,涉及盘点权限夹具、销售创建夹具和旧商品模板路径断言,与本 PR 无关。Refs #34