You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refs #389. That PR moved the cloud login device-link URL to openUrl(...) so it opens in the user's system browser instead of being routed through Donut's profile selector. After that flow no longer needs the profile-selector path, handle_url_open should remain an internal deep-link/startup URL helper only, not a frontend-invokable Tauri command.
This also fixes the Rust CI failure reported by test_no_unused_tauri_commands, where handle_url_open was exported in generate_handler! but had no frontend invoke(...) caller.
How to test
Run pnpm format && pnpm lint && pnpm test.
Confirm test_no_unused_tauri_commands passes and reports all exported Tauri commands are used.
Review src-tauri/src/lib.rs and confirm handle_url_open is still called from deep-link/startup URL handling, but is no longer exported through tauri::generate_handler!.
Local checks run:
cargo test tests::test_no_unused_tauri_commands -- --nocapture
Ran pnpm format && pnpm lint && pnpm test locally and it passes
I tested the changes myself by running the app locally
Updated translations in all locale files (if UI text changed; no UI text changed)
AI usage
I used AI to help write this PR
AI helped inspect the failing PR CI logs, relate the failure to #389, and prepare the minimal Rust cleanup. The final diff and checks were reviewed locally.
This PR correctly removes handle_url_open from the Tauri command registry since it's only called internally (deep-link handler, startup URL processing) and never invoked from the frontend — fixing the test_no_unused_tauri_commands CI failure.
Code review: The diff removes #[tauri::command] and the generate_handler![] entry for handle_url_open. The function remains as a plain async fn and is still called directly at three sites in the setup closure (deep-link on_open_url, startup URL, and pending URL processing), so no dead-code issue. The function signature (AppHandle, String → Result<(), String>) works fine without the command macro since callers already use it as a direct Rust call. No frontend invoke("handle_url_open", …) exists post-#389, and handle_url_open isn't in the mcp_only_commands allowlist, confirming it has no programmatic callers either. No translation or UI changes involved.
Hi there :) Thanks for the PR. I'll close it as I have already fixed it locally, just wasn't able to publish it as I have a large update coming up. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR fix?
No existing issue.
Refs #389. That PR moved the cloud login device-link URL to
openUrl(...)so it opens in the user's system browser instead of being routed through Donut's profile selector. After that flow no longer needs the profile-selector path,handle_url_openshould remain an internal deep-link/startup URL helper only, not a frontend-invokable Tauri command.This also fixes the Rust CI failure reported by
test_no_unused_tauri_commands, wherehandle_url_openwas exported ingenerate_handler!but had no frontendinvoke(...)caller.How to test
pnpm format && pnpm lint && pnpm test.test_no_unused_tauri_commandspasses and reports all exported Tauri commands are used.src-tauri/src/lib.rsand confirmhandle_url_openis still called from deep-link/startup URL handling, but is no longer exported throughtauri::generate_handler!.Local checks run:
cargo test tests::test_no_unused_tauri_commands -- --nocapturepnpm format && pnpm lint && pnpm testChecklist
pnpm format && pnpm lint && pnpm testlocally and it passesAI usage
AI helped inspect the failing PR CI logs, relate the failure to #389, and prepare the minimal Rust cleanup. The final diff and checks were reviewed locally.