feat: ban jsdoc blocks and cap line-comment runs - #985
Merged
Conversation
Adopts @zgeoff/oxlint-config 0.1.0, whose zgeoff/no-jsdoc and zgeoff/max-consecutive-line-comments rules replace the prose comment rules in the code-style skill. Deletes every JSDoc block lint covers and cuts every comment run over three lines, keeping only the facts whose cause lives outside the file as line comments.
|
Important Review skippedToo many files! This PR contains 1121 files, which is 971 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1121)
You can disable this status message by setting the |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
🍹
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Re-trigger cubic
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adopts
@zgeoff/oxlint-config0.1.0, whosezgeoff/no-jsdocandzgeoff/max-consecutive-line-commentsrules replace the prose comment rules in the code-style skill. A comment now holds only the reason the obvious alternative is wrong when the cause lives outside the file, and a caller-facing rule lives in a test name or the subsystem doc.infra/sdksstays as is, since lint already ignores it.bunfig.tomlcarries a dated exclude; an upkeep issue tracks its removal.Testing
bun run typecheckpassesbun run testpassesbun run lintpasses