Skip to content

fix(oxlint-config): treat a digit as a camelCase boundary after a verb #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zgeoff merged 1 commit into from
Jul 15, 2026
Merged

fix(oxlint-config): treat a digit as a camelCase boundary after a verb #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/oxlint-config/function-verb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ function isVerbMatch(name, verb, bareAllowed) {
return bareAllowed;
}

return name.startsWith(verb) && /[A-Z]/u.test(name.charAt(verb.length));
// a digit also ends the verb: acronyms like 2FA start camelCase segments
return name.startsWith(verb) && /[A-Z0-9]/u.test(name.charAt(verb.length));
}

function findAllowedVerb(name, verbs) {
Expand Down
24 changes: 24 additions & 0 deletions packages/oxlint-config/plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,30 @@ test('it matches a verb only at a camelCase boundary', async () => {
expect(result.exitCode).toBe(1);
});

test('it accepts a digit as the boundary after a verb', async () => {
const source = [
'export function run2FA(): void {}',
'',
'export function get2FAVerificationURI(): string {',
" return '';",
'}',
'',
].join('\n');

const result = await runLint(source, false, { 'zgeoff/function-verb': 'error' });

expect(result.exitCode).toBe(0);
});

test('it flags a banned verb at a digit boundary', async () => {
const source = 'export function save2FABackupCodes(): void {}\n';

const result = await runLint(source, false, { 'zgeoff/function-verb': 'error' });

expect(result.exitCode).toBe(1);
expect(result.stdout).toInclude("banned verb 'save'");
});

test('it skips PascalCase names, object-literal properties, getters, and setters', async () => {
const source = [
'export function Component(): null {',
Expand Down