Fix Swift 6 actor-isolation warning in InspectDomainIntent#3
Merged
Conversation
The app target sets SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor, so DomainReportBuilder and DomainInspectionService are MainActor-isolated. The unmarked perform() ran nonisolated, so calling build(from:) triggered an "expression is 'async' but is not marked with 'await'" warning (an error in the Swift 6 language mode). Mark perform() @mainactor to match AddToWatchlistIntent.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Marks
InspectDomainIntent.perform()as@MainActorto resolve a Swift 6 language-mode error surfaced as a warning today:Why
The app target sets
SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor, soDomainReportBuilderandDomainInspectionServiceareMainActor-isolated. The unmarkedperform()ran nonisolated, so the synchronousDomainReportBuilder().build(from:)call needed an actor hop. Rather than scatterawaits, this marksperform()@MainActorto match the siblingAddToWatchlistIntent.perform(). The network work still suspends viaawait inspectSnapshot(...), so the main actor is not blocked.Verification
xcodebuild build(schemeDomainDig, iOS 26 simulator) → BUILD SUCCEEDEDis 'async' but is not marked with 'await'warnings remain in the build log