chore: drop the release workflow#3
Merged
Merged
Conversation
The workflow turned a v* tag into an empty GitHub release. For a library with no binaries to attach, that is exactly what the Releases button in the UI does, so it earned nothing and had never once succeeded: the v0.3.1 runs were denied by a read-only GITHUB_TOKEN, and the v0.3.2 run raced a release published by hand and got a 422. Releases are cut in the UI, which also creates the tag. Go resolves tags through the module proxy, so nothing about publishing depends on this. Worth knowing if it ever comes back: it passed github.ref, so the title rendered as "Release refs/tags/v0.3.2". It wants github.ref_name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow turned a
v*tag into an empty GitHub release. This is a librarywith no binaries to attach, so that is precisely what the Releases button in the
UI already does — and releases are being cut in the UI, which creates the tag
itself.
It had also never once succeeded:
v0.3.1runs failed withResource not accessible by integration. Theworkflow had no
permissions:block, soGITHUB_TOKENwas read-only and couldnot create a release. This is why
v0.3.1has a tag but no release. Thatpermissions gap was fixed in b70d3dd (the CodeQL finding), so the
v0.3.2rungot further.
v0.3.2run reached the API and failed with422 Release.tag_name already exists— it raced the release published by hand moments earlier.Nothing about publishing depends on this workflow: Go resolves tags through the
module proxy, not GitHub releases.
v0.3.2is already on proxy.golang.orgpointing at b80180e.
ci.ymlandgo.ymlare untouched, so build, test, lint, and CodeQL still runon every push and PR.
Worth knowing if it ever comes back: it passed
github.ref, so the titlerendered as
Release refs/tags/v0.3.2. It wantsgithub.ref_name.