Repository navigation
Conversation
A second build beside an earlier IPA stopped at the pack on Windows, twice over: - "AttributeError: module 'os' has no attribute 'pread'" in match(): pack_ipa.py compares and copies entries of the earlier IPA with os.pread, which Windows' Python does not have. pread() now uses os.pread where it exists and seek + read otherwise. - then "PermissionError: [WinError 5] Access denied: '<ipa>.partial' -> '<ipa>'": the earlier IPA was still open (load_index keeps it for the reused entries) when os.replace put the new one in its place, and Windows refuses to replace an open file. It is closed once every entry is written, before the replace. The first build passed only because there was no earlier IPA. Checked: packing the same folder twice with os.pread removed and an os.replace that refuses an open destination (as on Windows) fails with each error before the change and writes a valid IPA (zipfile testzip) after it. Pokémon Legends: Z-A split build on Windows 11: the pack after the first change failed with the second error, as described. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDGHF5LyEKSqoK23EvYr6W
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
On Windows, a second build beside an earlier IPA stopped at the pack, in two places in turn:
AttributeError: module 'os' has no attribute 'pread'inmatch():pack_ipa.pycompares and copies entries of the earlier IPA withos.pread, which Windows' Python does not have.pread()now usesos.preadwhere it exists and seek + read otherwise.PermissionError: [WinError 5] Access denied: '<ipa>.partial' -> '<ipa>': the earlier IPA was still open whenos.replaceput the new one in its place (load_indexkeeps it open for the reused entries), and Windows refuses to replace an open file. It is now closed once every entry is written, before the replace.The first build only worked because there was no earlier IPA yet.
Checked
os.preadremoved and anos.replacethat refuses an open destination (as on Windows) fails with each error before the change. After it, the pack writes a valid IPA (zipfile.testzip).os.preadexists and the early close changes nothing, but no pack was run there.Docs
🤖 Generated with Claude Code
https://claude.ai/code/session_01VDGHF5LyEKSqoK23EvYr6W