Skip to content

ActorUnkRMSD: Unify code structure between RMSX files#94

Open
Mityno wants to merge 1 commit into
zeldaret:mainfrom
Mityno:ActorUnkRMSD
Open

ActorUnkRMSD: Unify code structure between RMSX files#94
Mityno wants to merge 1 commit into
zeldaret:mainfrom
Mityno:ActorUnkRMSD

Conversation

@Mityno

@Mityno Mityno commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Also a small fix

fix: Change type of ActorUnkRMSD.mUnk_158 that was too big to unk32 as placeholder
@decomp-dev

decomp-dev Bot commented Jun 27, 2026

Copy link
Copy Markdown

Report for eur (af4e4dc - 6089e23)

📈 Matched code: 6.30% (+0.00%, +36 bytes)

✅ 1 new match
Unit Item Bytes Before After
src/063_Shrine/Actor/ActorUnkRMSD ActorProfileUnkRMSD::Create() +1 99.89% 100.00%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
src/063_Shrine/Actor/ActorUnkRMSD ActorUnkRMSD::ActorUnkRMSD() +16 26.31% 39.93%
src/063_Shrine/Actor/ActorUnkRMSD ActorUnkRMSD::~ActorUnkRMSD() +8 66.67% 83.17%
src/063_Shrine/Actor/ActorUnkRMSD ActorUnkRMSD::~ActorUnkRMSD() +7 71.43% 85.57%

Report for jp (af4e4dc - 6089e23)

📈 Matched code: 6.27% (+0.00%, +36 bytes)

✅ 1 new match
Unit Item Bytes Before After
src/063_Shrine/Actor/ActorUnkRMSD ActorProfileUnkRMSD::Create() +1 99.89% 100.00%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
src/063_Shrine/Actor/ActorUnkRMSD ActorUnkRMSD::ActorUnkRMSD() +16 26.31% 39.93%
src/063_Shrine/Actor/ActorUnkRMSD ActorUnkRMSD::~ActorUnkRMSD() +8 66.67% 83.17%
src/063_Shrine/Actor/ActorUnkRMSD ActorUnkRMSD::~ActorUnkRMSD() +7 71.43% 85.57%

@Mityno

Mityno commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

I'm preparing another PR for other RMSX files that have some exact duplicate functions.
They all inherit from a parent class that is not Actor directly (same parent class for all), right now I'm duplicating a placeholder for it in every RMSX file (including this one). We should maybe discuss how to deal with that (I don't know how to delink the initial class yet, because I think it is needed atm).

Let me know if you think the new syntax for GetResource is okay, I copied it from some other file with similar access pattern.

@Mityno Mityno changed the title Unify code structure to fit other RMSX files ActorUnkRMSD: Unify code structure to fit other RMSX files Jun 27, 2026
@Mityno Mityno changed the title ActorUnkRMSD: Unify code structure to fit other RMSX files ActorUnkRMSD: Unify code structure to match other RMSX files Jun 27, 2026
@Mityno Mityno changed the title ActorUnkRMSD: Unify code structure to match other RMSX files ActorUnkRMSD: Unify code structure between RMSX files Jun 27, 2026
@Mityno Mityno marked this pull request as ready for review June 27, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant