ActorUnkRMSD: Unify code structure between RMSX files#94
Open
Mityno wants to merge 1 commit into
Open
Conversation
fix: Change type of ActorUnkRMSD.mUnk_158 that was too big to unk32 as placeholder
Report for eur (af4e4dc - 6089e23)📈 Matched code: 6.30% (+0.00%, +36 bytes) ✅ 1 new match
📈 3 improvements in unmatched items
Report for jp (af4e4dc - 6089e23)📈 Matched code: 6.27% (+0.00%, +36 bytes) ✅ 1 new match
📈 3 improvements in unmatched items
|
Contributor
Author
|
I'm preparing another PR for other RMSX files that have some exact duplicate functions. Let me know if you think the new syntax for GetResource is okay, I copied it from some other file with similar access pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a small fix