Skip to content

action: decompile 19 isFinished/isChangeable/oneShot_ overrides#172

Closed
alexgsonic1-pixel wants to merge 9 commits into
zeldaret:masterfrom
alexgsonic1-pixel:pr-172
Closed

action: decompile 19 isFinished/isChangeable/oneShot_ overrides#172
alexgsonic1-pixel wants to merge 9 commits into
zeldaret:masterfrom
alexgsonic1-pixel:pr-172

Conversation

@alexgsonic1-pixel

@alexgsonic1-pixel alexgsonic1-pixel commented Jun 23, 2026

Copy link
Copy Markdown

Changes

Group 1: isFinishedAS(0,0) delegation (13 functions)

All 18 bytes, same pattern:
eturn const_cast<T*>(this)->isFinishedAS(0, 0);`n

  • AnmUpDownMove, GanonSmallDamage, GanonThrowFireBall, GanonThrowTornado
  • GetUpBase, OnetimeHoverASPlay, SiteBossLswordAtk, SiteBossSpearAttackBase
  • SiteBossSwordAttackBase, SiteBossThrowParts, SmallDamage, GuardianMiniFinalBeamMove
  • GanonBarrierOn

Group 2: isChangeable member checks (3 functions)

  • BlownOff: mChangeableState == 1 (offset 0xec)
  • StalEnemyBlownOff: mChangeableState2 > 1 (offset 0x154)
  • ForkWaitCloseGanonShoutMsgClose: !*mInBeastGanonVoiceSequence_a`n

Group 3: Unique patterns (4 functions)

  • AppearNumTargets::oneShot_() - ui::setShowGolfCount() + return truen- **ActionWithAS::isFinished()** - mFlags || isFinishedAS(0,0)n- FreeMove::isChangeable() - *mIsChangeable_s`n

Base class decompilation

  • Ragdoll: 80 bytes of internal state members (gap 0xc0->0x110)
  • StalEnemyBlownOff: 40 bytes of gap (0x130->0x157)

All 19 functions updated from U/W to O in uking_functions.csv.


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant