various: fix mismatches in some action stubs and ResourceMgrTask#171
Open
alexgsonic1-pixel wants to merge 1 commit into
Open
various: fix mismatches in some action stubs and ResourceMgrTask#171alexgsonic1-pixel wants to merge 1 commit into
alexgsonic1-pixel wants to merge 1 commit into
Conversation
Pistonight
reviewed
Jun 23, 2026
Author
|
Done — inlined |
d7ce43e to
969f104
Compare
Collaborator
|
Okay, I see you are still working on decompiling other actions. When you are done please change the PR title again to something that fits better (I changed it for you because I thought you were done :p). Then let me know and I can take another look |
8d77e68 to
20cb829
Compare
Author
|
Sorry about the commit noise - was experimenting with batch decompilation and things got messy. Cleaned up now, just the original 4 functions. Title is fine as-is. Ready for review when you have time! |
Collaborator
|
No problem, one last thing, can you squash all of your changes into one commit? This allows us to have a clean merge history |
Pistonight
approved these changes
Jun 23, 2026
20cb829 to
003de4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
action::On::calc_ and action::Off::calc_
action::PlayerStoleOpenBase::calc_
ksys::res::ResourceMgrTask::setCompactionStopped
All functions updated from W/m to O in uking_functions.csv.
This change is