Skip to content

Fix Clang-23 RC build - #2482

Draft
evantypanski wants to merge 5 commits into
mainfrom
topic/etyp/transitive-include-fix
Draft

Fix Clang-23 RC build#2482
evantypanski wants to merge 5 commits into
mainfrom
topic/etyp/transitive-include-fix

Conversation

@evantypanski

@evantypanski evantypanski commented Aug 25, 2026

Copy link
Copy Markdown
Member

draft since I'm going to look at other stuff too (and so I make sure to come back to this), this isn't urgent.

Just tested Clang 23 RC3 and hit an error building Zeek:

In file included from /Users/etyp/src/zeek/auxil/spicy/hilti/runtime/src/backtrace.cc:6:
/Users/etyp/src/zeek/auxil/spicy/hilti/runtime/include/hilti/rt/backtrace.h:57:9: error: use of undeclared identifier 'free'
   57 |         free(dname); // NOLINT
      |         ^~~~
1 error generated.

Also changed this to fix some warnings, as well.

Note this fixes warnings in fiber/ - I did that as patches (see zeek/fiber#1). Unless they respond upstream to the other patch, I don't see much reason to not mildly maintain it ourselves.

@codspeed-hq

codspeed-hq Bot commented Aug 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 43 untouched benchmarks


Comparing topic/etyp/transitive-include-fix (e68109d) with main (9274feb)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (877b266) during the generation of this report, so 9274feb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

This was included transitively but should not be.
Thi `/` fix was only proper for MSVC. It broke when using an absolute
path on Mac. I used `-isystem /Library/...` when testing Clang 23.1 RC.
We had a few pragmas, but this one couldn't actually be fixed by
pragmas since the warning technically happened in a system include.
Bleh.
@evantypanski
evantypanski force-pushed the topic/etyp/transitive-include-fix branch from 945b8b4 to e68109d Compare August 25, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant