[windows] fix windows build - #2276
Merged
Merged
Conversation
mamaorha
force-pushed
the
ms/windows/spicy
branch
8 times, most recently
from
March 10, 2026 17:17
57f5332 to
db4b4bf
Compare
Merging this PR will degrade performance by 5.37%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | iterate_set[len:1] |
590 ns | 559.2 ns | +5.51% |
| ❌ | iterate_bytes[len:1] |
1 µs | 1.1 µs | -5.37% |
| ⚡ | iterate_vector[len:1] |
1.1 µs | 1.1 µs | +5.52% |
Comparing mamaorha:ms/windows/spicy (7c74427) with main (1c5b216)
mamaorha
force-pushed
the
ms/windows/spicy
branch
4 times, most recently
from
March 10, 2026 20:47
c7eef10 to
f32dfc7
Compare
bbannier
requested changes
Mar 11, 2026
mamaorha
force-pushed
the
ms/windows/spicy
branch
4 times, most recently
from
March 11, 2026 16:05
8c9b518 to
dad0daa
Compare
mamaorha
marked this pull request as draft
March 12, 2026 07:42
mamaorha
force-pushed
the
ms/windows/spicy
branch
5 times, most recently
from
March 14, 2026 11:37
f01c949 to
287257d
Compare
mamaorha
commented
Mar 14, 2026
mamaorha
commented
Mar 14, 2026
mamaorha
force-pushed
the
ms/windows/spicy
branch
from
March 14, 2026 12:37
9dc6ad5 to
8068b39
Compare
mamaorha
marked this pull request as ready for review
March 14, 2026 13:12
mamaorha
force-pushed
the
ms/windows/spicy
branch
from
March 14, 2026 13:39
8068b39 to
76b1a1d
Compare
mamaorha
force-pushed
the
ms/windows/spicy
branch
from
March 16, 2026 11:15
fecc8ef to
9a5e46f
Compare
bbannier
reviewed
Mar 17, 2026
bbannier
reviewed
Mar 17, 2026
mamaorha
force-pushed
the
ms/windows/spicy
branch
2 times, most recently
from
March 18, 2026 10:01
3d76451 to
995003e
Compare
bbannier
reviewed
Mar 18, 2026
mamaorha
force-pushed
the
ms/windows/spicy
branch
3 times, most recently
from
March 18, 2026 14:17
134eb8a to
e9ef00f
Compare
This adds a first iteration for adding Windows support for Spicy. With this patch the code builds, and unit tests pass. We also tested that this version of Spicy is usably in a fixed up version of Zeek.
The previous formatting confused the spellchecker.
bbannier
force-pushed
the
ms/windows/spicy
branch
from
March 19, 2026 16:40
9da01c0 to
7c74427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.