Use local source tree for zkg in shiv command - #247
Merged
Conversation
By providing "zkg" we caused `pip install` to install from PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my local Zeek tree I swapped the
auxil/package-managersubmodule out for some of our current branch work, and after installing I noticed that the zkg version kept reportingThat is, the local version of zkg made no difference to the install. I think that's because simply passing
zkgto shiv causes it to just pass that on topip install, which then pulls it down from PyPI, where 3.1.0 is the latest.The first thing I noticed was that I kept getting
in the build, which I eventually tracked down to the contents of
~/.cache/pip— not obvious. After blowing that away, I noticed it still didwhich eventually led me to this tweak after reading up on
shiv. Seems to be working for me.@bbannier fyi