Drop the per-class colours - #1239
Merged
Merged
Conversation
They did not survive contact with a real screen. At the size a chip actually renders, the wash flattened the palette: three of five classes came out the same teal and the last a washed-out salmon, so the colour said nothing the name did not already say -- while adding five hues to a page whose accent is orange. The chips and the row tags keep their neutral treatment. The name was doing the work all along. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for voluble-nougat-015dd1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1238 was squash-merged before this landed on its branch, so master currently has the colours — the squash is even titled "…with a colour per class". This is only the removal.
Why
They didn't survive contact with a real screen. At the size a chip actually renders, the 14% wash flattened the palette: three of five classes came out the same teal and the last a washed-out salmon. The colour said nothing the name hadn't already said, while putting five hues on a page whose accent is orange.
The chips and the row tags go back to their neutral treatment. The names were doing the work all along.
Deletes
utils/misc/classColor.jsand the$hue/$washbranches inChip; the class filter itself is untouched.51 tests, build clean.