Fix "Select larger syntax node" for Rust doc comments#50395
Closed
wetneb wants to merge 1 commit intozed-industries:mainfrom
Closed
Fix "Select larger syntax node" for Rust doc comments#50395wetneb wants to merge 1 commit intozed-industries:mainfrom
wetneb wants to merge 1 commit intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @wetneb on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
zed-community-bot
Bot
added
the
first contribution
Fixes zed-industries#44331. This switches to a version of the Rust tree-sitter parser which correctly attaches the doc comments to the nodes they annotate. This new parser also contains a range of improvements to the parsing of other aspects of the language, meaning that the query files required more adaptations in other places.
wetneb
force-pushed
the
44331-fix-rust-doc-comment-handling
branch
from
ff037ce to
03c63fd
Compare
cla-bot
Bot
added
the
cla-signed
Author
|
Some more queries need updating for the changes introduced in the grammar, I'll see if it's doable. |
Contributor
|
Thank you, will close this draft as stale for now to keep the queue cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44331.
This switches to a version of the Rust tree-sitter parser which correctly attaches the doc comments to the nodes they annotate.
This new parser also contains a range of improvements to the parsing of other aspects of the language, meaning that the query files required more adaptations in other places. You can see the details of those changes in the commit log of the grammar. Many of such changes have been submitted upstream, but the upstream repo isn't very actively maintained.
Release Notes:
tree-sitter-rust-orchardparser