Skip to content

Fix unnecessary unsafe block warning#20774

Closed
zelenevn wants to merge 1 commit intozed-industries:mainfrom
zelenevn:fix-warning
Closed

Fix unnecessary unsafe block warning#20774
zelenevn wants to merge 1 commit intozed-industries:mainfrom
zelenevn:fix-warning

Conversation

@zelenevn
Copy link
Copy Markdown

Closes #20773

Release Notes:

  • N/A

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Nov 16, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @zelenevn on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zelenevn
Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Nov 16, 2024
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Nov 16, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant
Copy link
Copy Markdown
Member

Thank you for the PR, but removing this unsafe block requires Rust 1.82, which we have not yet upgraded to.

The PR for upgrading to that version of Rust is here: #19349

Zed should always be built with the version of Rust specified in our rust-toolchain.toml:

channel = "1.81"

@maxdeviant maxdeviant closed this Nov 16, 2024
@zelenevn zelenevn deleted the fix-warning branch November 16, 2024 20:16
@zelenevn
Copy link
Copy Markdown
Author

@maxdeviant Hello! Thank you very much for the explanations. I'm sorry, I didn't know about that; I'll be more careful next time. Locally, I am indeed using version 1.82.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary unsafe block warning

2 participants