Add new YmmeLua extension - #7447
Open
tacc-tacc wants to merge 1 commit into
Open
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @tacc-tacc on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @tacc-tacc on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I'd like to be considered this extension to be added. The mentioned is a fork of current EmmyLua extension with two features that extension lacks:
dbg.tcpListen()) at the beggining of the scripts. This "stains" all the tested scripts and it is needed then to clean up before uploading to a repo or everywhere it is needed. Besides, I'm too lazy to open the console, calllua (script).luaand then call the debugger from the IDE. Why not to do these two steps at once?require("emmy_core")), and therefore you need to have this repo inside your CWD or link the folder from the same script your are running, which is also a stain that you have to clean before publishing the script somewhere else.I thought this module should replace the current EmmyLua, however looking at the EmmyLua DAP module it is all like that's the whole objective of that DAP: to be called from some process that is already running instead of calling itself.
Thanks for reviewing my contribution and I hope somehow will be useful for the community.