Claude/explore repo s75up#2
Open
zealtv wants to merge 69 commits into
Open
Conversation
- bash/start-laptop.sh: run plantsOS on laptop with MCP2221A USB I2C (PD with GUI, no jackd, auto-detect paths, configurable PD_BIN) - bash/stop-laptop.sh: kill laptop processes - python/io/io_mpr121_debug.py: standalone MPR121 monitor with live terminal bar display of electrode 0 values, configurable addresses - python/io/main.py: --monitor flag launches the debug monitor - python/requirements-laptop.txt: blinka + hidapi for MCP2221A https://claude.ai/code/session_01NdRBsXFfMMJ2v9REtY99Bj
The critical bug: switch_patch_callback called stop.sh inline, which runs "pkill python" — killing helper.py itself before start.sh could run. System would stop and never restart. Fix: spawn a detached bash process (via setsid) to handle stop/start. Bash survives "pkill python" since it's not a python process. Also: - validate main.pd exists before switching or after cloning patches - add 120s timeout to git clone and pullpatch (prevents hangs) - remove redundant git pull after clone --recursive - use realpath for script paths (safe in detached process) https://claude.ai/code/session_01NdRBsXFfMMJ2v9REtY99Bj
Extra double-quote on the pd launch line opened a string that never closed, making bash treat the rest of the script as a string literal and fail at line 109 with unexpected EOF. https://claude.ai/code/session_01NdRBsXFfMMJ2v9REtY99Bj
Save the active patch selection before git restore wipes it, then write it back after git pull so patch choice survives updates. https://claude.ai/code/session_01NdRBsXFfMMJ2v9REtY99Bj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.