fix(ci): update deprecated actions, inline Docker publishing#558
Merged
Conversation
- Update actions/checkout v2→v4 and actions/setup-go v4→v5 (v2 uses Node.js 12, removed from GitHub runners → startup_failure) - Replace reusable workflow dependencies with inline Docker steps (zcash/.github workflows added unnecessary complexity) - Add zodlinc/lightwalletd Docker Hub publishing alongside electriccoinco - Remove unnecessary matrix strategy (single Go version)
y4ssi
force-pushed
the
fix/ci-docker-publishing-v2
branch
from
8e9826a to
3ef6833
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #556 — v0.4.19 Docker image was never published because CI has been broken since GitHub removed Node.js 12 runners.
actions/checkoutv2→v4 andactions/setup-gov4→v5 — v2 uses Node.js 12, which was removed from GitHub Actions runners, causingstartup_failureon every CI runzcash/.githubshared workflows) with inline Docker build/push steps — simpler, no cross-repo dependencyzodlinc/lightwalletdDocker Hub publishing alongsideelectriccoincov0.4.19 images were already manually pushed to both registries:
electriccoinco/lightwalletd:v0.4.19zodlinc/lightwalletd:v0.4.19Test plan