Draft
Conversation
This commit is the squash of name changes that convert the "src" stub-directoy for binary placement to "bin", which is .gitincluded and whose contents are ignored. The reference is updated across the codebase. i.e. src --> bin including in the readme. include bin systematic src-->bin replacement, note zcash-cli refs are likely obsolete ignore "bin" contents it is a stub directory for-binaries
str4d
reviewed
Mar 20, 2026
| with: | ||
| name: zebrad-${{ matrix.name }} | ||
| path: ./src | ||
| path: ./bin |
Collaborator
There was a problem hiding this comment.
When creating stacked PRs, note the PR you are building on top of in the top comment, so that reviewers know to ignore those commits. (I originally asked to separate this out into a separate PR because it makes review harder, then I realised this was stacked on #47.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a gRPC service to support calling the zainod stateservice backed gRPC service.
This is the first test that exercises the state-service get_lightd_info gRPC.. there does not exist one in zaino.
Based on #47.