Add regtest block relay test and remove sync workaround#64
Draft
oxarbitrage wants to merge 1 commit intomainfrom
Draft
Add regtest block relay test and remove sync workaround#64oxarbitrage wants to merge 1 commit intomainfrom
oxarbitrage wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on ZcashFoundation/zebra#10403
util.py: Remove the node-restart workaround fromrebuild_cache(). Sync now relies solely onsync_blocks(), which is the correct behavior once the Zebra fix lands.regtest_block_relay.py: New regression test for bug(network): Zebra broadcasting in regtest mode ZcashFoundation/zebra#10332 (comment). Three nodes in a linearA -- B -- Ctopology; node A mines 10 blocks; asserts all nodes reach height 10. This is the minimal reproduction case from the issue.