Skip to content
This repository was archived by the owner on Dec 5, 2022. It is now read-only.

Conversation

@vigneshshanmugam
Copy link
Collaborator

@vigneshshanmugam vigneshshanmugam commented Jan 28, 2019

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #282 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   99.55%   99.56%   +<.01%     
==========================================
  Files          17       19       +2     
  Lines         670      684      +14     
  Branches      127      128       +1     
==========================================
+ Hits          667      681      +14     
  Misses          3        3
Impacted Files Coverage Δ
lib/agent-store.js 100% <100%> (ø)
lib/constants.js 100% <100%> (ø)
lib/request-fragment.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52812a3...412171a. Read the comment docs.

@zalando zalando deleted a comment from codecov bot Jan 28, 2019

class AgentStore {
constructor() {
const defaultAgentOpts = { socketActiveTTL: SOCKET_TTL };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The socket ttl should be configurable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I was thinking the same as well, Plus have to come up with custom config options for circuit breaker pool settings + metrics + caching of fragments..

I will come up with some proposal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought for a while about this and I think we can customize all of the logic in a client library like perron(or create one specific for tailor - or give PR to perron to make it work). Perron already supports circuit breaker logic for clients and we can easy add cache specific logic as well..

I will give PR to perron once i have sometime to work on some features.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants