Skip to content

fix(ingest): accept empty convex run output for the complete migration lock #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isuttell merged 1 commit into from
Sep 14, 2026
Merged

fix(ingest): accept empty convex run output for the complete migration lock #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/ingest-recovery/agent-migration-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,8 @@ export async function controlPlaneMigrationLock(
throw new Error(
`Control-plane migration lock failed (${code}, ${diagnostic.length} diagnostic bytes)`,
);
const result: unknown = JSON.parse(output);
// `convex run` prints nothing when a function returns null, which is the `complete` contract.
const result: unknown = output.trim() === '' ? null : JSON.parse(output);
if (
(phase === 'begin' && typeof result !== 'boolean') ||
(phase === 'complete' && result !== null)
Expand Down