Share one TypeScript program in server-fn surface tests - #612
Merged
Merged
Conversation
… tests Build the control-panel TypeScript program once per file and reuse it across cases so hosted Verify no longer times out under runner contention. Issue: SPL-386 Co-authored-by: Isaac Suttell <isaac@zaks.io>
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
isuttell
marked this pull request as ready for review
September 16, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server-fn-surface-test-helpers.test.tsrebuilt a control-panel TypeScriptProgramon every case. That sat near vitest's 5s default under runner contention and made hostedVerifyflake on unrelated PRs.This PR builds the program once in
beforeAlland reuses it across cases. Assertions and helper behavior are unchanged.@splitch/statsis a different shape (one-off dynamic import), so it is not included.Changes
sourcePrograminbeforeAllcreateServerFnSurfaceDiscoveryfor all casesRisk: LOW
Test plan
Recorded on head
f338e6a5(Node v24.17.0, pnpm 11.8.0).pnpm --filter @splitch/control-panel testpnpm verify:ci --forcegreen: 106/106, 8m25.935s (507048ms); surface file 5076ms under the full parallel graph (first case 503ms)Verifygreen onf338e6a5(run 35134277209)Issue: SPL-386
Linear Issue: SPL-386
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.