Zero-scope flags list prints columns like App-scoped reads - #610
Merged
Merged
Conversation
Zero-scope `flags list` printed indented JSON while App-scoped reads used columns. Reuse the Flag-read renderer, grouped by org/app, for hydrated and --summary output. --json stays the unchanged envelope. Issue: SPL-547 Co-authored-by: Isaac Suttell <isaac@zaks.io>
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zero-scope
splitch flags listprinted indented JSON while App-scopedflags list --appused columns.--summarypromised compact human columns on both paths and only kept that promise for the App-scoped read.This change renders the principal-wide list with the same Flag-read primitives, grouped by
org.slug/app.keyplus the canonical App ID.Changes
formatHydratedFlag/formatFlagSummaryListforprincipal_flags_listhuman output--jsonas the unchanged principal envelope--summaryhelp with the App-scoped "compact human columns" wordingRisk: LOW
apps/cli)terminalTextflags listchanges from indented JSON to columns;--jsonis unchangedTest plan
pnpm --filter @splitch/cli testpnpm --filter @splitch/cli typecheckverify:commit(knip, format, lint, typecheck, secrets)verify:pushVerifyon the PR headIssue: SPL-547
Linear Issue: SPL-547
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.