Skip to content

Zero-scope flags list prints columns like App-scoped reads - #610

Merged
isuttell merged 3 commits into
mainfrom
cursor/spl-547-flags-list-columns-a8fc
Sep 16, 2026
Merged

isuttell merged 3 commits into
mainfrom
cursor/spl-547-flags-list-columns-a8fc

Conversation

@isuttell

@isuttell isuttell commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Zero-scope splitch flags list printed indented JSON while App-scoped flags list --app used columns. --summary promised compact human columns on both paths and only kept that promise for the App-scoped read.

This change renders the principal-wide list with the same Flag-read primitives, grouped by org.slug/app.key plus the canonical App ID.

Changes

  • Reuse formatHydratedFlag / formatFlagSummaryList for principal_flags_list human output
  • Group Flags by App; keep --json as the unchanged principal envelope
  • Preserve empty-catalog and truncation notices, and fail loud on contract mismatches
  • Align --summary help with the App-scoped "compact human columns" wording
  • Add focused formatter and CLI tests for multi-App, empty, truncation, hydrated, summary, and JSON pass-through

Risk: LOW

  • Areas touched: CLI Flag-read human renderer only (apps/cli)
  • Security: no credentials or Targeting Keys added; App headers still pass through terminalText
  • Performance: in-memory grouping of an already-bounded list
  • Breaking: human output for zero-scope flags list changes from indented JSON to columns; --json is unchanged

Test plan

  • pnpm --filter @splitch/cli test
  • pnpm --filter @splitch/cli typecheck
  • Pre-commit verify:commit (knip, format, lint, typecheck, secrets)
  • Pre-push verify:push
  • Hosted Verify on the PR head

Issue: SPL-547

Linear Issue: SPL-547

Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Zero-scope `flags list` printed indented JSON while App-scoped reads
used columns. Reuse the Flag-read renderer, grouped by org/app, for
hydrated and --summary output. --json stays the unchanged envelope.

Issue: SPL-547

Co-authored-by: Isaac Suttell <isaac@zaks.io>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include @coderabbitai review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 4bba728e-3b77-4e38-bd91-5d340f8987bc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@isuttell
isuttell merged commit a6283a3 into main Sep 16, 2026
4 checks passed
@isuttell
isuttell deleted the cursor/spl-547-flags-list-columns-a8fc branch September 16, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants