Fix quickstart consumer smoke negative control to test missing Targeting Key

[isuttell]

Summary

The packed SDK consumer smoke treated any TypeScript failure as proof that omitting targetingKey is rejected. The stale-snippet transform left a dangling comma (evaluate(..., {, })), so the negative control could pass for a syntax error instead of the required Targeting Key contract.

Changes

• stripTargetingKeyFromSnippet now removes targetingKey: userId without leaving a dangling comma, and leaves optional neighbors such as idempotencyKey intact.
• The consumer-smoke negative control requires TypeScript to report that targetingKey is missing. Object-literal syntax errors and a successful typecheck (optional Targeting Key) fail the guard.
• Helper unit tests cover evaluate and evaluateDetails call shapes, syntax validity, and the optional-targetingKey mutation.

Risk: LOW

• Areas touched: SDK consumer-smoke helpers and their unit tests only
• Security: no credentials, Targeting Keys, or customer data added to artifacts or logs
• Performance: none
• Breaking: none; public evaluate contract and optional evaluation idempotency keys are unchanged

Test plan

• node --test packages/sdk/scripts/extract-quickstart-snippet.test.mjs
• pnpm --filter @splitch/sdk test (306 vitest + 19 node:test passed)
• pnpm --filter @splitch/sdk typecheck
• pnpm --filter @splitch/sdk test:consumer-smoke (positive packed smoke + stale targetingKey guard)
• pnpm verify:push

Issue: SPL-626

Linear Issue: SPL-626

  

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include @coderabbitai review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 70921e8e-bc42-4612-89f9-930c92e68e71

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}