Repository navigation
fix: repair main's preflight — API snapshot, RUSTSEC-2026-0285, platform-boundary violations - #1219
Merged
Merged
Conversation
210cabf (expose canonical process migration primitives) added public re-exports without regenerating docs/api_snapshot_rust.txt, so the public API snapshot gate fails every preflight. The diff is additive only: no rename, removal or reordered parameter (#849). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cargo audit --deny warnings fails on main (scheduled Security audit and every PR) on rustls 0.23.40. Lockfile-only bump to the patched 0.23.45 (rustls-webpki 0.103.13 -> 0.103.15 follows). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…latform trees Fixes the 13 platform-boundary Dylint errors on main from 1f21fe8 (foreground.rs) and 210cabf (semantic_priority.rs): - Unix `foreground::exec` and the host-specific foreground tests now live in platform_{linux,macos,win}/foreground.rs; the neutral facade re-exports the selected tree via lib.rs's single cfg_select!. - ProcessPriority::nice_value reads PRIORITY_NICE_LOW/HIGH constants defined per tree (Windows 1/-15, Unix 10/-5) instead of cfg!(windows). - Test fixtures build Commands through foreground::tests::fixture_command so the reviewed spawn-path allowlist entry still covers them. No public API change; docs/api_snapshot_rust.txt unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
zackees
changed the title
…emoved 265b024 recorded the foreground.rs / semantic_priority.rs host selectors and native imports in the migration baseline (429 -> 443 rows) without updating test_bootstrap_ledgers_are_valid, which still expects 429. The previous commit moved that code into the platform trees, so the rows are stale; removing them returns the ledger to 429 and shrinks the debt. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs
main's PR preflight, which fails for every PR (blocks #1217, part of zackees/setup-soldr#528). Three causes:docs/api_snapshot_rust.txtregenerated for the new exports (f2c2a22).Cargo.lockbumped to rustls 0.23.45 (8ab797d, cherry-picked from fix(deps): rustls 0.23.45 for RUSTSEC-2026-0285 #1218).crates/running-process-platform-internal/src/foreground.rs(from 1f21fe8) andsrc/semantic_priority.rs(from 210cabf) (8e9a333):foreground::execand the host-specific foreground tests move toplatform_{linux,macos,win}/foreground.rs. The neutral facade glob-re-exports the selected tree through the singlecfg_select!inlib.rs. Windows exports noexec, same as before.ProcessPriority::nice_valuenow reads per-treePRIORITY_NICE_LOW/PRIORITY_NICE_HIGH(Windows 1/-15, Unix 10/-5) instead ofcfg!(windows).foreground::tests::fixture_command, so the existing spawn-path allowlist entry still covers them. No new waivers, allowlist entries or baselines.Supersedes #1218.
RED → GREEN (
cargo dylint --pattern running-process-platform-boundary --workspace, nightly-2026-04-16)could not compile running-process-platform-internal due to 13 previous errorsat foreground.rs:41,43,59,99,111,129,154,174,205,215×2 and semantic_priority.rs:24,25.Validation (local, Linux x86_64)
./lint: All checks passed, including the spawn-path guard and the API snapshot gatecargo fmt --all -- --check: passcargo clippy --workspace --all-targets -D warnings: pass on host,x86_64-pc-windows-msvc,aarch64-apple-darwinandx86_64-apple-darwincargo build --workspace: passcargo audit --deny warnings: passcargo test -p running-process-platform-internal: 128 pass, including all moved foreground tests. 1 failure is environmental and unrelated:current_executable_exposes_a_gnu_build_id, because the local linker emits no GNU build-id note.🤖 Generated with Claude Code
4. Stale baseline count (
tests/test_platform_boundary.py::test_bootstrap_ledgers_are_valid,assert 443 == 429): 265b024 added 14 baseline rows for exactly theforeground.rs/semantic_priority.rsviolations without updating the test. With those violations moved into the platform trees, the rows are stale and are removed; the ledger is back to 429 rows (validate_ledger,manifest_dependency_violations,neutral_facade_contract_violationsall empty).