Repository navigation
fix: give the fork-lock test hooks C linkage (#619) - #625
Merged
Merged
Conversation
Wrap the MI_DEBUG heaps-lock test hooks in extern "C", matching the other test hooks in internal.h, so test-fork-locks.c links as C whether or not the library is compiled as C++. Reverts #623's compile-test-as-C++ workaround.
Local-Gate: v1 tree=d2a10acfef865c6dfea38201230f9c0368efb86d secs=59 lanes=lint:run
Ci-Attestation: {"at":1792965286,"gate":"python/all/lint","host":"linux-x86_64","key":"ce16a1154e5cad93293e2e09c3e87dae0d737ffe74c64db4967e7d26bc85ea19","lane":"lint","parents":["eea8867618915649c03188db161d45226d37ab5d"],"secs":59,"stamp":"a8b2323b2cfbe651cf265bc41a491760","tree":"d2a10acfef865c6dfea38201230f9c0368efb86d","v":1,"via":"run"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #623 (#619). Wraps the four MI_DEBUG heaps-lock test hooks in
include/mimalloc/internal.hinextern "C", the same pattern the file already uses for the other test hooks, sotest-fork-locks.clinks as plain C whether or not the library is compiled as C++. Reverts #623's add-to-LANGUAGE-CXX workaround. Second commit regenerates the vendored amalgamation (rule 2: separate commit).Verified locally, Linux gcc Debug:
MI_USE_CXX=ONandOFFboth build fully;test-fork-locks,-prof-env,-spawn-prof-envpass in both.