Repository navigation
ci: perf-ab sanity gate judges head against max(base, null arm) (#620) - #624
Merged
Merged
Conversation
A single bimodal base sample (drain RSS 48.3 vs null 208.0 MiB in run
39896572843) aborted a campaign the null arm reproduced. With --null-arm,
screen head against the per-metric worse of the two base runs.
Local-Gate: v1 tree=2513449976a263b4ffdbcad5abf733bd38e8f940 secs=62 lanes=lint:run
Ci-Attestation: {"at":1792798726,"gate":"python/all/lint","host":"linux-x86_64","key":"9241646da94324de4e0c5f44e6050bef2db7f18250ef225a4226a804f195ca1b","lane":"lint","parents":["aaef948845f03eecd7e80b29196a4e891bf55444"],"secs":62,"stamp":"ea51a21011d8b9a78e7a952ebddb4aab","tree":"2513449976a263b4ffdbcad5abf733bd38e8f940","v":1,"via":"run"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620.
The first-repetition sanity gate (#573) compared head with a single base sample. In run 39896572843 base drain RSS read 48.3 MiB (low mode of a bimodal sample) while the null arm — the same base binary — read 208.0, so head's 208.5 aborted the campaign.
With
--null-arm, head is now screened againstsanity_reference(base, null)= per-metric max of the two base runs. Without a null arm the gate is unchanged. The per-cell ledger still judges every rep against the null noise floor, so a real leak still fails there; the gate's1.5x + 8 MiBstill catches the #572-class leak whenever base and null agree.Test:
test_sanity_gate_reference_absorbs_null_arm_spreadreplays the run's numbers.ci/tests/test_perf_ab.py: 74 passed.