Repository navigation
fix(ci): show cancelling during run teardown - #689
Merged
Merged
Conversation
Local-Gate: v1 tree=3918643635b92589e07e9e3cfe9e894a02d5bb75 secs=338 lanes=rust:run,tests:run
Ci-Attestation: {"at":1792297864,"gate":"rust/all/fmt","host":"linux-x86_64","key":"2bb88017254c5eb7a135ad4d0a0781dbf216953d41be67d8b32cbf4f3792cb91","lane":"rust","parents":["84a8d9172a7ad434c19a2e0a62385428d2c17464"],"secs":317,"stamp":"77ee0e6f85cfe6c22bc1a9454ab8c0ca","tree":"3918643635b92589e07e9e3cfe9e894a02d5bb75","v":1,"via":"run"}
Ci-Attestation: {"at":1792297864,"gate":"rust/all/boundary","host":"linux-x86_64","key":"2bb88017254c5eb7a135ad4d0a0781dbf216953d41be67d8b32cbf4f3792cb91","lane":"rust","parents":["84a8d9172a7ad434c19a2e0a62385428d2c17464"],"secs":317,"stamp":"718b1326c2de9070254ecafb025fd422","tree":"3918643635b92589e07e9e3cfe9e894a02d5bb75","v":1,"via":"run"}
Ci-Attestation: {"at":1792297864,"gate":"rust/x86_64-unknown-linux-gnu/clippy","host":"linux-x86_64","key":"2bb88017254c5eb7a135ad4d0a0781dbf216953d41be67d8b32cbf4f3792cb91","lane":"rust","parents":["84a8d9172a7ad434c19a2e0a62385428d2c17464"],"secs":317,"stamp":"adb2d89ba8475bb5bb673a04bcfa1108","tree":"3918643635b92589e07e9e3cfe9e894a02d5bb75","v":1,"via":"run"}
Ci-Attestation: {"at":1792297864,"gate":"rust/x86_64-unknown-linux-gnu/test","host":"linux-x86_64","key":"2bb88017254c5eb7a135ad4d0a0781dbf216953d41be67d8b32cbf4f3792cb91","lane":"rust","parents":["84a8d9172a7ad434c19a2e0a62385428d2c17464"],"secs":317,"stamp":"5c2e424c21e8341d0303274b97af0d8b","tree":"3918643635b92589e07e9e3cfe9e894a02d5bb75","v":1,"via":"run"}
Ci-Attestation: {"at":1792297864,"gate":"python/all/static","host":"linux-x86_64","key":"01e357f3b1ce5737ab88126a8ce9fd8f3745edd0a749d822f8e4b6363121cd96","lane":"tests","parents":["84a8d9172a7ad434c19a2e0a62385428d2c17464"],"secs":338,"stamp":"f85ac68cb151877f82705129520d7eca","tree":"3918643635b92589e07e9e3cfe9e894a02d5bb75","v":1,"via":"run"}
Ci-Attestation: {"at":1792297864,"gate":"general/all/ci-policy","host":"linux-x86_64","key":"01e357f3b1ce5737ab88126a8ce9fd8f3745edd0a749d822f8e4b6363121cd96","lane":"tests","parents":["84a8d9172a7ad434c19a2e0a62385428d2c17464"],"secs":338,"stamp":"b3f59b3bcbe11e54a458f808d8e2f3f6","tree":"3918643635b92589e07e9e3cfe9e894a02d5bb75","v":1,"via":"run"}
Ci-Attestation: {"at":1792297864,"gate":"python/x86_64-unknown-linux-gnu/test","host":"linux-x86_64","key":"01e357f3b1ce5737ab88126a8ce9fd8f3745edd0a749d822f8e4b6363121cd96","lane":"tests","parents":["84a8d9172a7ad434c19a2e0a62385428d2c17464"],"secs":338,"stamp":"0868a4ceb3d959fe244598744af7b75e","tree":"3918643635b92589e07e9e3cfe9e894a02d5bb75","v":1,"via":"run"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #675. Part of #668.
Record an accepted cancellation immediately with
cancel_requested_atwhile the run remainsrunningfor scheduler and teardown ownership. The CLI, dashboard, widget, and live status events render that phase ascancelling; completion remainsdone/cancelled. The optional field keeps older protocol peers compatible.Evidence:
runningrather thancancelling.bosn run --task rust-test../lintand strict Clippy passed.rustandtestslanes on the committed tree (tree3918643635b9).clud-reviewfound one dashboard action mismatch, fixed before the gate.