Fix Lua configuration and animation crashes - #23
Open
Alyx-Clark wants to merge 1 commit into
Open
Conversation
Alyx-Clark
marked this pull request as ready for review
September 11, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Hyprview with a Lua Hyprland configuration can dereference a null legacy
configuration value. After fixing that, animation callbacks can still abort when
they try to lock a weak reference to a uniquely owned animation.
Register and read settings through Hyprland's typed configuration API, compare
animation pointers without locking them, and expose
hl.plugin.hyprview.toggle(args)for Lua callbacks. Explicitoffnow also closesan overview opened with
on. Lua gestures remain available while the overview isopen so a separate downward gesture can dismiss it. Legacy gesture registration
and blocking are retained for legacy configurations.
Includes Lua examples and a nested integration test that targets only the
compositor it launches. Physical gesture behavior was confirmed on the local desktop;
the automated test invokes the same Lua callbacks directly.
Validation: built against Hyprland 0.56.2; the nested integration test passed at
100% and 200% scale, including three open/close cycles across two workspaces,
reload/reopen, and unload while open. No fullscreen behavior changes are included
in this compatibility commit. Legacy registration was retained and its typed
value support checked against the matching Hyprland source; legacy runtime
behavior and older Hyprland versions were not tested.