Repository navigation
refactor(cli): share ops argument parsing - #1407
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seven
opssubcommands repeated help/error handling, and five parsers independently maintained the same eight common flags. Route these through two private helpers so common connection, credential, and output options have one parsing implementation. Common-option validation now returnsResult<(), String>instead of cloning the options.Command-specific parsing and validation remain local. The change preserves defaults, last-value-wins behavior, flag-like values, first-position help handling, error precedence, exit codes, and credential redaction. Production code decreases by 92 lines; table-driven coverage expands across all seven subcommands.
Validation:
cargo test --locked -p webcodex-cli --lib tests::ops -- --quiet: 45 tests passed before the change; 46 passed in the final tree, including the existing HTTP/credential and provider-diagnostic tests.cargo fmt -p webcodex-cli -- --checkandgit diff --checkpassed.