[RL] Forward multimodal inputs through Omni rollouts - #3
Closed
JingwenGu0829 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OmniGenerateFnsend canonicalimages,audios, andvideosfieldsWhy
The standard Miles VLM path already serializes images, but the custom Omni rollout hook bypasses that request builder and only sends audio. That prevents the stacked sglang-omni
/generatecontract from receiving the full multimodal input.This draft is stacked on
hayden/omni-rl-clean-20260708from PR #2. Its companion change is sgl-project/sglang-omni#1032, based onhayden/rl-higgs-qwen3-clean-20260708.Validation
Draft follow-up
Run image/audio rollout-to-training parity against the companion sglang-omni branch. A general serializer for in-memory video tensors remains separate work; this draft fails those inputs explicitly.