refactor(logging): simplified prints and add spinner#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Displays spinner while streaming:
When done:
Summary
Extract logging utilities into a dedicated module, add a terminal spinner for streaming requests, and simplify both startup and per-request log output.
Changes Made
src/deepseek_cursor_proxy/logging.py:ConsoleLogFormatter— custom formatter that hides timestamps/level prefixes in normal mode and shows full detail in verbose modeconfigure_logging()— sets up aStreamHandlerwith the appropriate formatterTerminalSpinner— animated spinner (Braille frames) for tty streams during streaming requestsserver.py:loggingusage withfrom .logging import LOG, TerminalSpinner, configure_loggingTerminalSpinnerlifecycle around streaming upstream requests (start before forwarding, stop on completion/error/disconnect)LOG.infocalls into concise key-value pairs, conditional on verbose modetool_countfrom request log line; renamed┌ cursorto┌ request; simplifiedlog_context_summarystatus outputlog_send_summarybehind verbose gatingtransform.pyandtunnel.py:import logging+LOG = logging.getLogger(...)withfrom .logging import LOGtests/test_server.py:ConsoleLogFormatter(info/warning formatting, verbose timestamp) andTerminalSpinner(tty vs non-tty behavior)