Implement JDT URI handler without creating temporary files.#67
Open
lucasec wants to merge 1 commit intoyveszoundi:mainfrom
Open
Implement JDT URI handler without creating temporary files.#67lucasec wants to merge 1 commit intoyveszoundi:mainfrom
lucasec wants to merge 1 commit intoyveszoundi:mainfrom
Conversation
This is an attempt to improve the JDT URI handler by patterning it after the built-in url-handler-mode. Rather than writing the class source to a temporary file and re-directing to it, this implements a more complex file name handler that allows visiting the jdt:// URI directly in Emacs with the source loaded directly into the buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to improve the JDT URI handler by patterning it after the built-in url-handler-mode. Rather than writing the class source to a temporary file and re-directing to it, this implements a more complex file name handler that allows visiting the jdt:// URI directly in Emacs with the source loaded directly into the buffer.
There are a few advantages to this approach:
ibuffer) which buffers are local source files and which are class sources pulled from the language serverAnd no loss of functionality:
jdt://URI).Would love for others to give this a try and let me know if you find any bugs.
There are also several improvements I would like to explore in the future, such as tweaking the URI scheme to enable
jdt://paths to be bookmarked or saved viadesktop-save-modeand restored later, without having to first navigate from a buffer with a running JDTLS. Also, the ability to interactively browse within a dependency artifact or the dependency tree could another gap between Emacs/JDTLS and mature IDEs such as IntelliJ.