Feat/version tracking - #2
Merged
Merged
Conversation
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var - Update actions/checkout to v5 - Update create-pull-request to v8 - Fix heredoc output syntax for changes
- Build both CPU and GPU images on PRs touching Dockerfiles - Verify images can start successfully - Triggers on PR to main or push to main for Dockerfile changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the project's Docker and GitHub Actions workflows, focusing on updating Node.js versions and enhancing automation for Docker image builds and version checks. The main changes include upgrading Node.js to version 22 in both CPU and GPU Dockerfiles, adding a new workflow for Docker builds, and updating the version-check workflow for better reliability and output formatting.
Dockerfile updates:
Dockerfile.cpuandDockerfile.gputo ensure the project uses the latest LTS features and security updates. [1] [2]GitHub Actions workflow enhancements:
.github/workflows/docker-build.ymlworkflow to automatically build and verify both CPU and GPU Docker images on pull requests and pushes affecting Docker-related files. This helps catch Docker build issues early.actions/checkoutaction to v5 in.github/workflows/version-check.ymlfor improved performance and security.FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: truein the version-check workflow to ensure compatibility with JavaScript actions.Version check workflow improvements:
peter-evans/create-pull-requestaction from v7 to v8 and explicitly set the GitHub token for authentication, ensuring smoother automated PR creation.VERSIONS.mdto simplify the workflow.