Review summary - #157
Open
samshao wants to merge 31 commits into
Open
Conversation
eServices - First batch of changes for Petition (form 2) (production)
Merge dev to main
eServices - Replicate data from repeatable panels to single text field (production)
…e-panels eServices - Adapt repeatable helpers client library to make it callable from AEM (production)
eServices - Add mechanism for overriding behaviour of accordion delete button (production)
eServices - Functions for repeatable signature (production)
…le-field eServices - Re-enable focus on first fillable field (production)
eServices - Navigation fixes (production)
eServices - Fix accordion tabs interoperability with keyboard (production)
…r-helpers eServices - Helper functions and focus after scribble signatures (production)
eServices - Dynamic signatures (production)
eServices - Canada Post API address component
heldersrvio
requested changes
Jun 12, 2026
heldersrvio
left a comment
Collaborator
There was a problem hiding this comment.
- Formatting broken for multiline fields
- The review page needs to look just like the review page in our forms now. Please create copies of our most recent forms (e.g. HSS/YHCIP and HSS/Children Dental Program/Enroll your child in the Yukon Children's Dental Program) and make sure the layout and styling matches that
- Remove unrelated code from the PR, such as the AdobeSign service and other client libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authoring dialog properties (set on the component node):
- excludedFields : String[] — field names to suppress (e.g. hidden tokens)
- showEditLinks : Boolean — whether to render "Edit" nav links per section