Repository navigation
Potential fix for code scanning alert no. 33: Cache Poisoning via caching of untrusted files - #427
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/yshavit/mdq/security/code-scanning/33
Best general fix: do not save cache entries in privileged/default-branch release workflows that may process untrusted or caller-controlled revisions. If caching is needed, isolate it to low-privilege PR workflows or strictly scope keys to trusted immutable refs and avoid saving when trust is uncertain.
Best single fix here (without changing build functionality): keep restore behavior for performance, but disable cache writes so poisoned content cannot be persisted. In GitHub Actions, replace
actions/cachewithactions/cache/restorefor this step. This preserves dependency restoration speed while removing the vulnerable “save” path that causes poisoning risk.Change required in
.github/workflows/build-release.yml:buildjob around lines 116–127, change the cache step fromuses: actions/cache@...touses: actions/cache/restore@....pathandkeyunchanged.No new imports, methods, or dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.
Some clippy improvements thrown in, to make CI happy.