fix: disable curl tests to prevent duplicate resolve.exe on Windows#3
Merged
Merged
Conversation
zoogies
approved these changes
May 29, 2026
zoogies
left a comment
zoogies
left a comment
Member
There was a problem hiding this comment.
LGTM! Always interesting to me how cmake causes different configure issues on different systems non-deterministically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error of "multiple rules generate Debug/resolve.exe during building on Windows. I looked through the build.ninja file and found the conflict in curl's test server utilities being built alongside the rest by seeing this path "_deps\curl-build\tests\server\resolve". Fixed by disabling the curl tests before curl gets fetched.