Skip to content

fix: add buffer-length check in libyep.c #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoogies merged 1 commit into from
May 31, 2026
+3 −5
Merged

fix: add buffer-length check in libyep.c #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/libyep.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,7 @@ static SDL_EnumerationResult SDLCALL _recurse_dir_callback(void *userdata, const
if (yep_pack_root_path != NULL) {
// Normalize the root path for comparison
char normalized_root[4096];
strncpy(normalized_root, yep_pack_root_path, sizeof(normalized_root) - 1);
normalized_root[sizeof(normalized_root) - 1] = '\0';
snprintf(normalized_root, sizeof(normalized_root), "%s", yep_pack_root_path);
normalize_path_separators(normalized_root);

// Calculate relative path from the original root
Expand All @@ -451,8 +450,7 @@ static SDL_EnumerationResult SDLCALL _recurse_dir_callback(void *userdata, const
relative_path = full_path + strlen(dirname) + 1;
} // Convert backslashes to forward slashes for consistent storage
char normalized_relative_path[256];
strncpy(normalized_relative_path, relative_path, sizeof(normalized_relative_path) - 1);
normalized_relative_path[sizeof(normalized_relative_path) - 1] = '\0';
snprintf(normalized_relative_path, sizeof(normalized_relative_path), "%s", relative_path);

for (char *p = normalized_relative_path; *p; p++) {
if (*p == '\\') {
Expand Down Expand Up @@ -480,7 +478,7 @@ static SDL_EnumerationResult SDLCALL _recurse_dir_callback(void *userdata, const
node->fullpath = strdup(full_path);

// set the name
sprintf(node->name, "%s", final_relative_path);
snprintf(node->name, 64, "%s", final_relative_path);
node->name[strlen(final_relative_path)] = '\0'; // ensure null termination

// add the node to the LL
Expand Down
Loading