Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The allowlist can produce an unusable or incomplete crate package.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR adds an explicit Cargo package file allowlist.
Changes:
- Limits published crate contents to selected source, configuration, documentation, license, and lockfile files.
File summaries
| File | Summary |
|---|---|
Cargo.toml |
Adds the package allowlist. Leading slashes make the patterns invalid for the package root, and assets/ is omitted despite being referenced by README.md. |
Review details
Suppressed comments (1)
Cargo.toml:11
- The new allowlist omits
assets/, butREADME.mdembedsassets/jnv-dark.svgandassets/jnv-light.svg. Packaging with this list will leave those README images out of the crate archive, producing broken links for package consumers; include the assets directory as well.
"/src/**",
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+10
to
+16
| include = [ | ||
| "/src/**", | ||
| "/default.toml", | ||
| "/README.md", | ||
| "/LICENSE", | ||
| "/Cargo.lock", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSIA