Skip to content

chore: move all packages to the default catalog - #243

Merged
yjoer merged 1 commit into
masterfrom
yj
Oct 11, 2026
Merged

yjoer merged 1 commit into
masterfrom
yj

Conversation

@yjoer

@yjoer yjoer commented Oct 11, 2026

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bc56374e-f0be-4156-8a62-60f89b7ddbda

📥 Commits

Reviewing files that changed from the base of the PR and between 52aa84a and b7a722b.


⛔ Files ignored due to path filters (2)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • uv.lock is excluded by !**/*.lock

📒 Files selected for processing (27)
  • examples/elasticsearch/search-ui/package.json
  • examples/grafana/prometheus/package.json
  • examples/grafana/prometheus/pyproject.toml
  • examples/grafana/prometheus/smartctl.py
  • examples/hatchet/typescript-connectors/package.json
  • examples/hatchet/typescript-simple/package.json
  • examples/http/_bench/package.json
  • examples/http/express/package.json
  • examples/http/fastify/package.json
  • examples/http/h-three/package.json
  • examples/http/orpc/package.json
  • examples/http/trpc/package.json
  • examples/node/basics/package.json
  • examples/react-server/next/package.json
  • examples/react-server/tanstack-start/package.json
  • examples/react-server/vite/package.json
  • examples/tanstack/start-solid/package.json
  • examples/tanstack/start-trpc/package.json
  • examples/tanstack/start/package.json
  • examples/temporal/typescript-ip-geolocation/package.json
  • examples/webpack/typescript-fastify/package.json
  • examples/webpack/typescript-http/package.json
  • package.json
  • packages/config/package.json
  • packages/webpack/package.json
  • pnpm-workspace.yaml
  • stories/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



Summary by CodeRabbit

  • Chores
    • Standardized dependency version references across project examples, packages, and stories using a shared workspace catalog.
    • Updated Grafana dashboard settings so the node variable is single-select; other listed variables remain multi-select.
    • Adjusted the Grafana SDK version used by the Python example.

Walkthrough

The workspace adds a pnpm dependency catalog and updates package manifests to use catalog references. The Grafana Prometheus example also changes its Python SDK version pin and makes its node dashboard variable single-select.

Changes

Workspace Dependency Catalog

Layer / File(s) Summary
Define the catalog
pnpm-workspace.yaml
Adds pinned versions for workspace dependencies in a pnpm catalog.
Update service and runtime examples
examples/elasticsearch/search-ui/package.json, examples/hatchet/*/package.json, examples/http/*/package.json, examples/node/basics/package.json, examples/temporal/typescript-ip-geolocation/package.json, examples/webpack/typescript-*/package.json
Replaces explicit dependency versions with catalog references in these example manifests.
Update framework and UI examples
examples/react-server/*/package.json, examples/tanstack/*/package.json, examples/grafana/prometheus/package.json, stories/package.json
Replaces listed dependency versions with catalog references.
Update workspace package manifests
package.json, packages/config/package.json, packages/webpack/package.json
Uses catalog references for listed dependencies. The config manifest also removes oxlint from devDependencies.

Grafana Prometheus Example

Layer / File(s) Summary
Change Python SDK version pin
examples/grafana/prometheus/pyproject.toml
Changes the grafana-foundation-sdk pin to 0.0.20.
Set node variable to single-select
examples/grafana/prometheus/smartctl.py
Disables multiple selections for the node dashboard variable.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b7a72

The workspace catalog and lockfile are synchronized, and the config package’s oxlint import is available through the root workspace. No actionable merge-blocking risk remains.

Pre-merge checks | Passed 3 | Failed 1 | Inconclusive 1

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (26 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check Inconclusive No pull request description was provided, so the change rationale and scope are not documented beyond the title. Add a brief description explaining that package dependencies are being moved to the shared default catalog and noting the catalog setup in pnpm-workspace.yaml.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check Passed The title accurately summarizes the main change: moving package dependency versions to the default catalog.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (26 skipped: 26 unsupported.)


  • Fix all pre-merge checks with AI
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checked the catalog page
And hopped through versions, stage by stage
The node now picks one leafy sprout
While package pins all sort themselves out
Then tucked the change beneath the moon 🌙

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@yjoer
yjoer merged commit d92f506 into master Oct 11, 2026
14 checks passed
@yjoer
yjoer deleted the yj branch October 11, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant