POC: Delta rest api#3
Open
yili-db wants to merge 1 commit into
Open
Conversation
yili-db
pushed a commit
that referenced
this pull request
Jul 17, 2026
…ests (unitycatalog#1646) **Stack 3/4** — split of unitycatalog#1554. Stacked on unitycatalog#1645. > Based on unitycatalog#1645 (which is based on unitycatalog#1644). GitHub shows the cumulative diff; **review only this PR's own commit** `3b76bc27`, and merge after unitycatalog#1645. ### What this PR does Wires metric-view support into the connector on Spark 4.2 and applies the review-driven refactors. - **Real 4.2 `ViewSupport` / `UCProxyViewSupport`**: `listViews` / `loadView` / `createView` / `dropView` / `renameView` (+ `loadTableOrView`), wrapping view-like UC rows as `MetadataTable + ViewInfo`; 4.0/4.1 stay no-ops. - **`UCSingleCatalog`** mixes in `TableViewCatalog` + `ViewSupport`, keeps a `ucProxy` handle, and calls the per-version `rejectIfShimmedView` hook from `loadTable`. - **`UCProxy`** view dispatch: `listUcTables` / `getUcTable` / `loadV1Table` extractions, view filtering in `listTables` / `dropTable`, 409 → already-exists mapping. - **`UCViewTypes`** (new): the view-type mapping (`viewLikeUcTypes` + predicates) moved **out of `UCSingleCatalog`** so the catalog stays focused on table management (@zhenghu's Slack ask). - **`UCColumnConversions`**: the view path's `Column` serializer folded in alongside the `StructField` one (from unitycatalog#1644), and the separate `UCColumnJson` deleted (@openinx's unify ask). - Comment/scaladoc cleanups (#3/unitycatalog#4/unitycatalog#10/unitycatalog#11) and the redundant-`proxy` fix (unitycatalog#9). ### Tests `UCViewProxySuite` (Spark 4.2 view CRUD), `UCProxySuite` view-filtering additions + shared `UCProxyTestFixture`, `UCColumnConversionsSuite`, and new `UCViewUnsupportedSuite` on **4.0/4.1** asserting metric views are unsupported there (explicit per-version coverage per @zhenghu). ### Stack 1. unitycatalog#1644 — extract `UCColumnConversions` 2. unitycatalog#1645 — shim scaffolding 3. **this PR** — view glue + `UCViewTypes` + unit tests 4. local-run e2e tests Verified: compiles on Spark 4.0/4.1/4.2; unit suites green on 4.0/4.1; the Spark-4.2 view suites compile against real 4.2 and run green in CI (they require a real Spark 4.2 runtime). This pull request and its description were written by Isaac. This PR is assisted by Isaac Autopilot: [View the full session spec, test plan, and artifacts](http://go/isaac-autopilot/cli-viewer/1782162701477/chen-wang_data). Signed-off-by: chen.wang <chen.wang@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
POC: Delta rest api