-
-
Notifications
You must be signed in to change notification settings - Fork 48
Fix di-web for theme pathMap configuration with multiple paths
#283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows you to use a directory array as the source of the view files, as described in the documentation of the Theme class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #283 +/- ##
=========================================
Coverage 99.51% 99.51%
Complexity 305 305
=========================================
Files 19 19
Lines 827 827
=========================================
Hits 823 823
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vjik
reviewed
Mar 18, 2025
vjik
requested changes
Mar 18, 2025
Member
vjik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
- add test
- add line to changelog
pathMap configuration with multiple paths
pathMap configuration with multiple pathsdi-web for theme pathMap configuration with multiple paths
vjik
approved these changes
May 16, 2025
samdark
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to use a directory array as the source of the view files, as described in the documentation of the Theme class
Without this, when configuring a theme with multiple paths, the following error occurs

now you can set up a theme as described in the Theme documentation, for multiple cascading directories, as this is the main functionality of Theme