Skip to content

Conversation

@mariovials
Copy link
Contributor

Allows you to use a directory array as the source of the view files, as described in the documentation of the Theme class

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Without this, when configuring a theme with multiple paths, the following error occurs
image

'yiisoft/view' => [
    'theme' => [
        'pathMap' => [
            '/app/views' => [
                '/app/themes/christmas',
                '/app/themes/basic',
            ],
        ],
        ...
    ],
],

now you can set up a theme as described in the Theme documentation, for multiple cascading directories, as this is the main functionality of Theme

allows you to use a directory array as the source of the view files, as described in the documentation of the Theme class
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (071a326) to head (b8ab0ec).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #283   +/-   ##
=========================================
  Coverage     99.51%   99.51%           
  Complexity      305      305           
=========================================
  Files            19       19           
  Lines           827      827           
=========================================
  Hits            823      823           
  Misses            4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark samdark requested a review from vjik March 18, 2025 17:24
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

  • add test
  • add line to changelog

@mariovials mariovials requested a review from vjik March 18, 2025 19:39
@vjik vjik changed the title Fix di-web for Theme pathMap configuration with multiple paths Fix di-web for theme pathMap configuration with multiple paths May 16, 2025
@vjik vjik changed the title Fix di-web for theme pathMap configuration with multiple paths Fix di-web for theme pathMap configuration with multiple paths May 16, 2025
@vjik vjik requested a review from a team May 16, 2025 05:56
@vjik vjik added the status:code review The pull request needs review. label May 16, 2025
@vjik vjik merged commit 29568d0 into yiisoft:master May 16, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants