Skip to content

Conversation

@DAGpro
Copy link
Contributor

@DAGpro DAGpro commented Sep 25, 2025

Q A
Is bugfix? ✔️/❌
New feature? ✔️
Breaks BC? ✔️

@DAGpro
Copy link
Contributor Author

DAGpro commented Sep 25, 2025

It is necessary to fix the tests in the data package in the BaseReaderWithLikeTestCase class in the testWithReader method

@DAGpro
Copy link
Contributor Author

DAGpro commented Sep 25, 2025

The All and None handlers in draft form )

@samdark samdark marked this pull request as draft September 26, 2025 08:46
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 87.03704% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.66%. Comparing base (087e695) to head (affaa3c).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...der/FilterHandler/LikeHandler/MysqlLikeHandler.php 0.00% 4 Missing ⚠️
.../FilterHandler/LikeHandler/PostgresLikeHandler.php 0.00% 4 Missing ⚠️
src/Reader/EntityReader.php 84.21% 3 Missing ⚠️
...er/FilterHandler/LikeHandler/SqliteLikeHandler.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master      #43       +/-   ##
=============================================
+ Coverage     80.76%   93.66%   +12.89%     
+ Complexity      116      102       -14     
=============================================
  Files            23       24        +1     
  Lines           312      300       -12     
=============================================
+ Hits            252      281       +29     
+ Misses           60       19       -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DAGpro DAGpro marked this pull request as ready for review September 28, 2025 19:24
@DAGpro
Copy link
Contributor Author

DAGpro commented Oct 2, 2025

@samdark reviews?

@samdark samdark merged commit feb947b into yiisoft:master Oct 2, 2025
52 of 53 checks passed
@samdark
Copy link
Member

samdark commented Oct 2, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants